search

integrations / slack

Bring your code to the conversations you care about with the GitHub and Slack integration
https://slack.github.com/
MIT License
3.07k stars 482 forks source link

Workflow name with emoji has spaces stripped #1743

Open houserx-jmcc opened 1 year ago

houserx-jmcc commented 1 year ago

Describe the bug We have a workflow named ":rocket: Release" (a space between the emoji and word). When trying to subscribe to that workflow in Slack, the space between the emoji and text is automatically stripped regardless of how many spaces there are in the sub command. ":rocket: Release" becomes ":rocket:Release" which does not map to the actual workflow, so the notifications do not work.

Also, the workflow is not recognized unless it is defined as :rocket:Release, ':rocket:Release' does not work. This makes it show up incorrectly in the GitHub UI, but appears correctly in Slack and works for the subscription.

To Reproduce Steps to reproduce the behavior:

  1. Create a workflow with an emoji + space, such as :rocket: Release
  2. Attempt to subscribe to it in Slack (/github subscribe org/repo workflows:{name:":rocket: Release" branch:"master, staging"})
  3. See space between emoji and text stripped in response command

Expected behavior No whitespace is stripped in the workflow name when the command is registered.

Screenshots

Screenshot 2023-08-03 at 12 27 14 PM

Desktop (please complete the following information):

DanielPritchard commented 1 year ago

I am experiencing this too, any workflow with an emoji in the name does not subscribe correctly so we get no notifications for the builds (all my workflows have emojis in the name so they can be ordered and grouped together in the workflows list in githubs website)