integrations / slack

Bring your code to the conversations you care about with the GitHub and Slack integration
https://slack.github.com/
MIT License
3.07k stars 481 forks source link

When using deploy keys, it uses deploy key author not commit author for commit info #1774

Open MattPowersVD opened 1 year ago

MattPowersVD commented 1 year ago

Describe the bug It seems that the bot is not using the commit's author for SSH commits, but is instead using the author of the deploy key.

To Reproduce Steps to reproduce the behavior:

  1. Set up your GitHub repository as an SSH only repository.
  2. Make a deploy key. (Make sure this is NOT made by the same GitHub user you are going be committing with -- for testing purposes.)
  3. Commit and push to this repository using the SSH deploy key you made prior.
  4. Once the Slack Discord bot sends the message to your channel, it will have the author of the deploy key instead of the author of the commit as the stated author of the git commit.

Expected behavior The author of the git commit as shown in slack to be the same as shown in GitHub (and more specifically the actual one who committed the commit).

Screenshots image In the image above, the second commit is shown to be using the new deploy key (made by me). The first commit was using a deploy made by danv-vandata.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Not really anything else that I haven't already said.

timon0305 commented 1 year ago

ok

MattPowersVD commented 1 year ago

I have fixed the picture. It didn't copy both layers, so I had to re-upload it as just 1 layer.