integrations / slack

Bring your code to the conversations you care about with the GitHub and Slack integration
https://slack.github.com/
MIT License
2.98k stars 468 forks source link

Workflow subscriptions with emojis and spaces in the name don't work right #1790

Open simonista opened 8 months ago

simonista commented 8 months ago

Describe the bug Spaces before or after an emoji character in a workflow name are lost when subscribing.

To Reproduce Steps to reproduce the behavior:

  1. Issue this command: /github subscribe XXX workflows:{name:“:rocket: Production”, event:“workflow_dispatch”}
  2. The output is: This channel will receive notifications from XXX for: workflows:{name:":rocket:Production" event:"workflow_dispatch"}
  3. Notice that the space character between the rocket emoji and the rest of the name has been lost

Expected behavior The event name being subscribed to matches what was input

Screenshots CleanShot 2023-11-02 at 12 10 18@2x