search

integrations / slack

Bring your code to the conversations you care about with the GitHub and Slack integration
https://slack.github.com/
MIT License
2.98k stars 468 forks source link

Slack link previews cannot be removed by clicking the 'x' on the preview #1799

Closed kbehlers closed 7 months ago

kbehlers commented 7 months ago

Describe the bug When using the Github Slack App on Slack for Mac 4.35.126, attempting to click the 'x' on a link preview does not respond. The search bar then also becomes unresponsive, along with other buttons like the workspace switcher.

To Reproduce Steps to reproduce the behavior:

  1. The Github Slack app must be installed, if it is not installed, clicking the 'x' on the preview will work as expected.
  2. Paste any Github repo link (e.g. https://github.com/python/cpython) into a slack message and send.
  3. Wait for the link preview to display
  4. Hover over the link preview and click the 'x' to the left side of the link a. The link won't be removed, and no modal to confirm removing the link will appear.
  5. Attempt to focus the search bar by either clicking on it directly at the top of page or by pressing cmd+F or cmd+K a. The search bar won't appear

Expected behavior I would expect clicking the 'x' on the link preview to bring up the pop-up to remove the preview, just as it does when the Github Slack app is not installed, and just as Slack does with all other link previews for other sites. I would also expect clicking the 'x' to not disable other functionality within the app.

Screenshots

This is what happens when I click the 'x' and the Github Slack app is not installed. Notice the darkened background behind the modal.

Screen Shot 2023-11-08 at 10 04 31 AM

This is what happens when I click the 'x' and the Github Slack app is installed.

https://github.com/integrations/slack/assets/43154039/1549c180-a5e9-4a10-9b05-d47b5d4996be

Desktop (please complete the following information):

seredniy commented 7 months ago

+1

wayheming commented 7 months ago

+1

AndriiSmith commented 7 months ago

+1

kbehlers commented 7 months ago

I had also opened a ticket with Slack. They told me it was a known bug and they would notify me as soon as a fix became available. They just notified me the fix had released and reloading Slack should resolve the issue. After reload, removing link previews is now working on my machine using the Github Slack app.

I'll leave this ticket open for a day or two in case anyone else is still impacted.