search

integrations / slack

Bring your code to the conversations you care about with the GitHub and Slack integration
https://slack.github.com/
MIT License
2.98k stars 468 forks source link

PR review comments are not threaded #1806

Open rantoniuk opened 7 months ago

rantoniuk commented 7 months ago

Describe the bug When a repository is integrated with slack with the following settings:

This channel will receive notifications from ... for:
issues, pulls, commits, releases, deployments, workflows:{event:"pull_request" branch:your-default-branch}, reviews, comments

the notifications are too noisy when a PR review is happening.

see also #1729

Reproduction steps

  1. open a PR
  2. start a review process
  3. enter multiple comments on multiple different files of the PR
  4. submit the review with "changes requested" status

Expected behaviour I expect one message to be posted to slack and all the comments to be put in this message's thread.

Actual behaviour Multiple messages are posted - one per comment.

Desktop (please complete the following information): doesn't matter.

Smartphone (please complete the following information): doesn't matter.

mdwish commented 7 months ago

I have this issue too. All PRs and Reviews are sent to the channel by default. There doesnt seem to be any command to subscribe only to reviews:"threading" or "threads"

Screenshot 2023-11-29 at 12 14 40 PM
asontha commented 2 months ago

Same issue, I would really like it to only be in the reply thread and not "Also sent to the channel". It's duplicative and annoying.

jostster commented 1 month ago

Same, it creates WAY to much spam having it also sent to the channel