integrations / slack

Bring your code to the conversations you care about with GitHub's integration for Slack
https://slack.github.com/
MIT License
3.12k stars 490 forks source link

Link unfurling added by github bot despite settings to disable link preview #1807

Open ignaspa opened 1 year ago

ignaspa commented 1 year ago

Describe the bug The github bot adds link unfurling despite me having my slack settings set to disable link previews. What does this mean? It means usually when I paste a link into a message, when I send the message no additional link preview is taking up space. However, when I send a message which includes say a github PR hyperlink, the github bot goes and adds a link preview which I then I have to wait for and remove manually. See screenshot: image

See conversation with slack support image

To Reproduce Steps to reproduce the behavior:

  1. Go to slack Preferences > Messages & Media and disable Show text previews of linked websites
  2. Ensure you have the github bot integration running in your slack workspace
  3. Send a message with a github link, such as PR
  4. After sending the message, the message will promptly be expanded by github bot with a link unfurl (in this case showing the PR title and description)
  5. Press the little x in the top left of the preview to remove it

Expected behavior if I have the setting of link previews disabled I do not expect github bot to create previews (which I then manually have to remove) without my consent.

Screenshots See description above (screenshots inline)

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

jlrobins commented 2 weeks ago

My shop has a culture of not wanting the GitHub links unfurled. We waste time EVERY SINGLE DAY following up every message of ours containing a GitHub link and quickly hitting the 'x' button to declutter a conversation, channel, or thread.

That the bot neither honors our personal setting, nor can be communicated with on a per-user basis to one-time opt-out of automatic unfurling is infuriating.