search

integrations / slack

Bring your code to the conversations you care about with the GitHub and Slack integration
https://slack.github.com/
MIT License
2.98k stars 468 forks source link

Slack "double-check this link" now triggers on all embeds due to `#` #1854

Closed mscoutermarsh closed 2 months ago

mscoutermarsh commented 3 months ago

It seems slack has recently changed their behavior and now always shows a double-check this link warning when clicking any unfurl that starts with a #.

This makes clicking any pull request or issue unfurl from the GitHub + Slack app show the warning.

I found this reference on reddit

If anyone else ever Googles this and can't figure out the issue the problem occurs when links to external sites begin with a # mark. I assume this is to stop people clicking links that look like they are to internal Slack channels being taken to malicious third party sites.

jezcommits commented 3 months ago

👋 that's interesting because we link every PR and issue with the # 😅. I think we cannot avoid that alert and we should decide whether to remove the # or not from all the links. This decision should escalate to product. Change should not be super difficult so I will triage accordingly:

Based on our triage process we've assigned this issue the following priority:

Impact Severity Effort Priority
High Low Low 2

If you have additional details that could change this issue's priority, please follow up here so we can revisit.

cc @jlord

mscoutermarsh commented 3 months ago

Hi! Update: I've heard from Slack that they are fixing it on their end. 😄

jlord commented 3 months ago

Thanks @mscoutermarsh that's great news!

@jezcommits I think we can close this then and re-open should Slack actually not fix it and we see more reports 👍

jezcommits commented 3 months ago

awesome! Thanks for the update. I cannot close this issue since I don't have the option. @mscoutermarsh feel free to close this

broksonic21 commented 2 months ago

This is still continuing and happening on every click - any word back from Slack or additional way to solve?

mscoutermarsh commented 2 months ago

Same, I haven't heard anything from them.

jlord commented 2 months ago

I'm reaching out to see if I can get an update and will re-open this as it's still an issue.

jlord commented 2 months ago

They got back to me already and it is known/tracked on their end and being worked on. They'll let me know when it's resolved 👍

jlord commented 2 months ago

It should be resolved now they said 🎉