integrations / slack

Bring your code to the conversations you care about with the GitHub and Slack integration
https://slack.github.com/
MIT License
2.98k stars 468 forks source link

Subscribing to a specific feature is subscribing to all default features #1865

Open seancrater opened 3 months ago

seancrater commented 3 months ago

Describe the bug When I type /github subscribe owner/repo releases it is subscribing to a bunch of other features.

In this case, a colleague was deactivated so the subscription was closed so we no longer had a subscription for this repo. We were re-creating the subscription that had been closed by running the command GitHub suggested we run. The command passed to us didn't actually suggest correctly either, it was a global subscribe command rather than the specific features we'd been subscribed to initially but that wasn't a huge deal.

To Reproduce Steps to reproduce the behavior:

  1. In a Slack channel with a GitHub integration, run /github subscribe {owner}/{repo_name} releases
  2. Expect to only be subscribed to releases but it'll instead subscribe to issues, pulls, commits, releases, deployments

Expected behavior I'd expect when I pass a particular feature to subscribe to, that only that feature or list of features would be subscribed to but instead it is defaulting to a full list of features that I haven't passed in nor am I already subscribed to.

Screenshots image

Desktop (please complete the following information):

Additional context

bigdatadave commented 1 month ago

Can confirm seeing the same behaviour, however in our case it's in a brand new channel and there are no previous subscriptions. Specifying specific features works correctly for the unsubscribe action, just not for subscribe:

Screenshot 2024-05-10 at 4 28 54 PM