search

integrations / slack

Bring your code to the conversations you care about with the GitHub and Slack integration
https://slack.github.com/
MIT License
2.98k stars 468 forks source link

The preview of GitHub Issue URL does not properly escape angle brackets #1872

Open mame opened 2 months ago

mame commented 2 months ago

Describe the bug When a GitHub Issue has a string like <foo> in the code block, it is not properly escaped in the issue's Slack preview.

To Reproduce Steps to reproduce the behavior:

  1. Paste this URL to any Slack workspace (with GitHub integration enabled)
  2. See only bar, instead of <foo|bar>

Expected behavior I expect <foo|bar> to be shown.

Screenshots image

Note that the bar is a link to URL foo.

image

Desktop (please complete the following information):

Additional context I have contacted on the GitHub security and have received prior permission to create this public issue here.