search

integrations / slack

Bring your code to the conversations you care about with the GitHub and Slack integration
https://slack.github.com/
MIT License
2.98k stars 468 forks source link

No notification for PR reviews #1877

Closed siferati closed 2 months ago

siferati commented 2 months ago

Describe the bug Notification for PR reviews isn't working.

To Reproduce Steps to reproduce the behavior:

  1. Invite github app to slack channel
  2. /github subscribe <owner/repo> reviews
  3. Assign reviewers to PRs
  4. There is no message nor notification for reviewers

Expected behavior There is a new message posted on slack when reviewers are assigned and reviewers receive a notification

Additional context Other notifications seem to work fine, the bot will correctly write messages whenever a PR is opened, closed, etc. But there is no message for when reviews are requested, so reviewers don't receive notifications. I've enabled reviews and the bot shows that reviews are subscribed correctly.

> /github subscribe <owner/repo> reviews
This channel will receive notifications from <owner/repo> for:
issues, pulls, commits, releases, deployments, **reviews**
siferati commented 2 months ago

I seem to have misunderstood the purpose of /github subscribe <owner/repo> reviews so I am closing this issue. It subscribes to PR reviews, which is working fine.

I was under the impression it would subscribe to review requests, which isn't the case and seems to not be implemented yet: