integrations / slack

Bring your code to the conversations you care about with the GitHub and Slack integration
https://slack.github.com/
MIT License
2.98k stars 468 forks source link

Feature Request: Support Non-ASCII Characters for Label filters #1907

Open stefafafan opened 4 weeks ago

stefafafan commented 4 weeks ago

Is your feature request related to a problem? Please describe. I am working at a Japanese company, and want to use this integration to filter notifications with a specific Japanese label (as Japanese developers, sometimes it is easier to set GitHub labels with Japanese characters).

For example, instead of bug, the Japanese alternative 不具合 is more readable for some, especially when we use GitHub with non-developers as a team.

I do notice in the README that english characters and emoji work, but since GitHub allows users to use Japanese characters, it seems annoying that this integration only takes into account English speaking communities. https://github.com/integrations/slack/blob/master/README.md#valid-filters

Describe the solution you'd like I would like the label filter to support Non-ASCII characters (i.e. support all types of labels that are able to be created on GitHub).

Describe alternatives you've considered Workaround is to just use English characters. However this does not help my original problem.

Additional context Below are some related issues. If the label regex/validation gets revised, all of these problems will get resolved.