search

integrations / slack

Bring your code to the conversations you care about with the GitHub and Slack integration
https://slack.github.com/
MIT License
2.98k stars 468 forks source link

Comments on PRs are being counted as reviews #1913

Open gregsdennis opened 3 weeks ago

gregsdennis commented 3 weeks ago

Describe the bug It appears that a recent change is causing comments on PRs to be counted as reviews. So when I subscribe to both comments and reviews, I receive two messages per comment on PRs.

This doesn't appear to affect issues, which is what leads me to believe the comments are counted as reviews.

To Reproduce Steps to reproduce the behavior:

  1. Subscribe to a repo and add comments and reviews.
  2. Find a PR in that repo and make a single comment.
  3. Look in Slack. Two messages should appear both indicating the single comment.

Expected behavior Only one message should appear.

Screenshots image

Note that the first message is a comment on an issue and only appears once.

The second and third comments are the same GH comment on a PR. Interestingly, when I deleted the comment in GH, only one of the Slack messages updated.

Desktop (please complete the following information):

I doubt this is a client issue, so OS/version shouldn't matter.