search

integrations / slack

Bring your code to the conversations you care about with the GitHub and Slack integration
https://slack.github.com/
MIT License
2.98k stars 468 forks source link

No longer auto-subscribed to Slack Threads for Pull Requests #1914

Closed jlogsdon closed 2 weeks ago

jlogsdon commented 2 weeks ago

Describe the bug We noticed today that at some point (recently, but not sure precisely when) we stopped being auto-subscribed for updates to the Slack Thread for a PR associated with our user account (such as assigned as a reviewer, or otherwise commenting on the PR). We still get @user tagged in the opening message of the thread, and Slack does ping us for those, but the behavior used to be that we would also automatically be subscribed for new posts in that thread.

We have not changed our GitHub integration settings.

To Reproduce

  1. Subscribe to pulls, comments and reviews 
    /github subscribe {repo} pulls
/github subscribe {repo} comments
/github subscribe {repo} reviews
  2. Have a Slack User linked to GitHub (so that it knows who they are in Slack)
  3. Open a PR and assign that user for review.
  4. Observe the PR is posted to Slack, and the user is mentioned, but will not be automatically subscribed to the thread for new updates.

Expected behavior I should be automatically subscribed to the thread for updates, as was previous behavior.

Screenshots

Screenshot 2024-06-13 at 2 17 07 PM

Desktop (please complete the following information):

Additional context

I am still automatically subscribed to threads in slack that I interact with directly. This does appear to be a specific change to the behavior of the Slack Integration with GitHub.

jlogsdon commented 2 weeks ago

Coincidentally it seems like this did start happening again around when I posted this? I'll keep an eye out and close if it seems better now.

jlogsdon commented 2 weeks ago

This does appear to be working now, closing this issue out.