search

integrations / slack

Bring your code to the conversations you care about with the GitHub and Slack integration
https://slack.github.com/
MIT License
3.06k stars 479 forks source link

Github app raised pull requests no longer strikethrough when approved/processed #1938

Open gyurikol opened 2 weeks ago

gyurikol commented 2 weeks ago

Describe the bug Github app previously would perform a strikethrough when a raised pull request was processed in some manner (approved). This has changed as of 30th of august 2024. In a team of collaborators, where the team is active in pull request support, this is super helpful. Before, people could click the link that would spawn moments after raised, and thinking the Pull request is awaiting processing. Now, without a strikethrough, we are hesitant, thinking that the Pull request is probably already approved. Now i am walking more blindly. This has snowball effect of slowness and reservations in pull request cycle while maintaining a rapid and fast moving development environment. I trust you can understand the impact when you have 50+ pull requests a day, trying to enable internal teams/collaborators and entire org with their respective changes.

To Reproduce Steps to reproduce the behavior:

  1. Click Github app notification
  2. Click raised pull request allocated to team of collaborators
  3. Oh look, pull request is already approved 1 minute ago

Expected behavior

  1. Click Github app notification
  2. Oh look, the Pull request link has a strikethrough, no need to click the link

Screenshots Screenshot denoting the day before (before line separator) show strikehthroughs of processed pr's. Proceeding pull requests after line are approved and no longer have strikethrough

Screenshot 2024-09-03 at 09 50 18

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

MakonnenMak commented 2 weeks ago

Running into this on my end as well.

andersthorbeck commented 2 weeks ago

I started experiencing this on 2024-08-29, at some point between 04:03 UTC (last time it worked) and 05:37 UTC (first time it didn't work). It is detrimental to productivity and the usefulness of the notifications as a whole, when I can no longer easily identify which reviews have already been handled by someone else on my team.

lukas-tide commented 1 week ago

Same is happening on my end. Last crossed out PR is on September 4th

belprm commented 1 week ago

Same issue here. It started on August 28th. I tried to authorize and set notifications again, but it didn't help.

nzupec-veza commented 1 week ago

I had been experiencing this issue since August 28th. But today it somehow started working again.

EDIT: doesn't work anymore for me as well. It worked just for a short period of time.

maor-graiber commented 6 days ago

We still experience this issue. Started at Aug 28

martinhausio commented 4 days ago

bump, same here and it is very disruptive to my regular workflow

nicholascapo commented 3 days ago

Broke for me between 2024-08-28T20:17:27Z and 2024-08-28T20:43:37Z