search

integrations / slack

Bring your code to the conversations you care about with the GitHub and Slack integration
https://slack.github.com/
MIT License
3.07k stars 481 forks source link

Subscriptions to "pulls" feature not working #1960

Open lamontadams opened 4 days ago

lamontadams commented 4 days ago

Describe the bug I'm not receiving notifications of PRs in a repo subscribed via /github subscribe owner/repo pulls. /github subscribe list features confirms the repo is subscribed to the pulls feature. Subscriptions to pulls in the same repo worked correctly in a different slack account - we have migrated to a new account due to acquisition and no subscriptions work on new slack account.

Unsure if dupe of https://github.com/integrations/slack/issues/1833 or not, please advise if so and will close.

To Reproduce Steps to reproduce the behavior:

  1. In a slack channel with the github app installed: /github subscribe owner/repo pulls
  2. Confirm subscription via /github subscribe list features
  3. Got to owner/repo in github, create a PR
  4. Note no notification appears in the subscribed slack channel.

Expected behavior Notification appears in the subscribed slack channel when a PR is created.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

angeliquejw commented 1 day ago

Here to report the same issue. Our team originally subscribed to a repo in June and things worked as expected. On 9/23, we attempted to subscribe to a second repo's pull requests and have not seen anything from the repo, despite the fact that /github subscribe list features shows the second repo.

mfitz commented 1 day ago

We're experiencing the same problem, both for PRs and issues.

Nothing unusual happened when subscribing to the repo from the Slack channel, and list features also looks normal:

/github subscribe list features

<group>/<repo>
issues, pulls, commits:'main', releases, deployments, reviews, branches, comments

We see notifications when new branches and releases are created but not when PRs or issues are created, or when comments are added to an issue.

We can create new issues on the repo from the Slack channel, so "pushing" to issues is working, but "pulling" from them is not.

Repos with older subscriptions are not affected; we still see Slack notifications for PRs and issues from those repos.