search

integrations / slack

Bring your code to the conversations you care about with GitHub's integration for Slack
https://slack.github.com/
MIT License
3.1k stars 489 forks source link

Notifications on re-requested PR review #832

Open annatfw opened 5 years ago

annatfw commented 5 years ago

A recent feature allows re-requesting review after changes are made, which notifies the reviewers.

https://github.blog/changelog/2019-02-21-re-request-review-on-a-pull-request/

Slack integration that would either notify reviewers, or (ideally; if possible at all) notify any subscriber that review for this PR has been re-requested would be greatly helpful.

welcome[bot] commented 5 years ago

Thanks for opening this issue! If you would like to help implement an improvement, read more about contributing and consider submitting a pull request.

keithhan-nsuslab commented 4 years ago

When can this accomplished? I'm looking forward to this.

danielgomezrico commented 4 years ago

It would be very nice to have this, Pull Panda have it, I have it but my coworkers cant use it because Pull Panda closed the doors joining github.

bombillazo commented 4 years ago

This feature would be great to speed up the dev pipeline, especially for remote work!

egemon commented 3 years ago

+1

danielgomezrico commented 3 years ago

We started using https://github.com/manosim/gitify and is totally awesome

andresovela commented 3 years ago

+1 We could really use this feature too

keithhan-nsuslab commented 3 years ago

We started using https://github.com/manosim/gitify and is totally awesome

Good alternative. But It seems to not support detailed notification setting. It means that I can't subscribe re-requested notification without anything else.

frankiea commented 3 years ago

+1 Really miss this feature now that Pull Panda is dead.

hblanko commented 3 years ago

+1 Our re-requested PR reviews often stall an unnecessary amount of time, as most interactions are notified on Slack excepting this one.

holsky-hivebuy commented 3 years ago

+1 we resort back to manually pinging people to re-review pull requests :(

filipszczepanski commented 3 years ago

+1

dw2kim commented 2 years ago

+1

rusik commented 2 years ago

+1

ebk46 commented 2 years ago

+1

jamietanna commented 2 years ago

I appreciate that people would like to +1 interest on this, but please use reactji on the original ask instead of adding a new comment to the thread.

Maybe the maintainers should lock this issue to prevent new comments.

bretthayes commented 2 years ago

A quick fix until this is implemented; if you convert your PR to a draft and then click the "Ready for review" button, it will re-trigger the notification in Slack.

Screen Shot 2022-04-06 at 12 10 27 PM

Screen Shot 2022-04-06 at 12 10 53 PM

rdhelms commented 8 months ago

Checking since this issue is still old - is this still the right issue to track for the feature to get PR re-request notifications? Or is there somewhere else I should look to see the most recent info?

binarymonkey84 commented 3 months ago

Definitely need this - just realised I wasn't getting notifications on PRs when they are re-requested... 🤦