integrations / slack

Bring your code to the conversations you care about with GitHub's integration for Slack
https://slack.github.com/
MIT License
3.1k stars 489 forks source link

GitHub Deployment notifications filter #942

Open derwasp opened 5 years ago

derwasp commented 5 years ago

Currently it's possible to create filtered subscription for a bunch of events, but it's not possible for the deployment events. Since we are deploying quite often, we have way too many notifications and in reality are only looking at the failed ones.

It would be extremely cool if we could filter based on the deployment state, like so: /github subscribe myawesomeorg/MyIncredibleProject deployments +status:failure

Related to #913

welcome[bot] commented 5 years ago

Thanks for opening this issue! If you would like to help implement an improvement, read more about contributing and consider submitting a pull request.

simonbrandhof commented 5 years ago

Filtering by environment is another use-case for this improvement.

stale[bot] commented 3 years ago

Is this still relevant? If so, just comment with any updates and we'll leave it open. Otherwise, if there is no further activity, it will be closed.

arielkirkwood commented 3 years ago

I think it’s still relevant.

raghera commented 3 years ago

I think it's still relevant. We only care about deployments to some envs not all and particularly failures.

almed4 commented 3 years ago

Agreed! We don't want to spam our whole org with dev deployments, but it's important for API consumers to know when we do releases :)

JoaquinFernandez commented 3 years ago

Yes, it is a use case for us a well, for notifying only on deployment failure

fbjork commented 2 years ago

+1

seanconrad1 commented 2 years ago

+1

tobiastornros commented 2 years ago

+1 for this. Vercel deployments are spamming in our channels...

earthpyy commented 2 years ago

+1 for this!

danwkennedy commented 2 years ago

Another use case: we only want to monitor deployments for a specific branch (ie. main). Right now, every PR that might kick off a build workflow is pushing its status status to our Slack channel.

tughril commented 2 years ago

+1 for this!

pratikyadav commented 2 years ago

+1 for Filtering by environment and state

kirqz23 commented 2 years ago

+1 filtering by env and state

jonathan-dunn-telus commented 2 years ago

+1 !!

seanconrad1 commented 2 years ago

+1

jrea commented 2 years ago

+1

TreeOfLearning commented 2 years ago

+2

tubbo commented 2 years ago

We use preview deployments for our staging environments, so using /github subscribe deployments is really noisy for us. Ideally, we'd like to filter deployment notifications to only the main branch, so one can see what has been pushed to production.

dlazares commented 2 years ago

+1, any updates on this as a feature?

styd commented 2 years ago

+1

jamie-unmind commented 2 years ago

+1

mdial89f commented 2 years ago

This feature is definitley in our "longed for" column. We deploy environments tracked by GH Environmnets/Deployments from 'n' number of branches, but only want the alerts for a few select branches to avoid alarm fatigue.
I absolutely love the notifications though, and how they auto update as the deployment status changes. Just need filtering and we're all set!

dstoyanoff commented 2 years ago

+1 for env filter

berryd commented 2 years ago

+1

benjaminpaige commented 2 years ago

+1 pretty please

am-cornelis commented 1 year ago

We'd also be using a feature like this, in particular filtering out on the workflow name

tihuan commented 1 year ago

+1 still hoping this get bumped in priority, or if there's any pointers on how to implement this, my team might be able to take a look. Thanks!

itaispiegel commented 1 year ago

+1

jackblanc commented 1 year ago

+1

jonathan-dunn-telus commented 1 year ago

+1 would be really helpful ! Thanks

Ibrahim-elouard commented 1 year ago

+1

metarsit-coinhako commented 1 year ago

+1

vbalazs commented 1 year ago

Please use the reactions to vote up the issue and avoid the unnecessary +1 comments 🙏 They notify all the issue subscribers every time. I always get excited that there is an update about this, just to see that it was an another spammy comment 😿

I don't wish to unsubscribe to this issue since I'm still interested in it.

Since the requirements and popularity here are quite clear, maybe the repo maintainers could consider locking this issue for external comments (and give a much needed update 🙏)

igor9silva commented 1 year ago

4 years in and still no option 🥲

My use case is very simple: I only want to notify for our production environment. Isn't it most people use case? What am I missing?

I tried with workflows instead of deployment, but no option as well.

styd commented 1 year ago

Hey, @igor9silva ! We had almost the same need as you. Only we separate the notifications to different channels in slack, e.g. production to #production-deployment channel and staging to #staging-deployment. We decided to switch to using this action in our workflows instead.

igor9silva commented 1 year ago

Hey, @igor9silva ! We had almost the same need as you. Only we separate the notifications to different channels in slack, e.g. production to #production-deployment channel and staging to #staging-deployment. We decided to switch to using this action in our workflows instead.

Thanks for the reference!

landsman commented 1 year ago

what the hell there is no filter for the environment of deployment?

opp-svega commented 1 year ago

+1

007vasy commented 1 year ago

+1

RZandvoort-VSM commented 1 year ago

+1

larsjoakimgrahn commented 1 year ago

Please do not continue commenting with +1 on this issue. Instead use reactions on the initial post. Writing +1 triggers a notification for every person who is following this issue.

eliasmistler commented 6 months ago

Are there any updates on this? This really seems like a basic feature that lots of people need, and I'm quite surprised nothing has happened in 4 years :/

igor9silva commented 6 months ago

They're to worried with Copilot

eliasmistler commented 6 months ago

Actually, looking at the docs, there is a new way to do this:

Don't use the deployments notifications:

/github unsubscribe my-org/my-repo deployments

Instead, use the worfklows feature:

/github subscribe my-org/my-repo workflows:{name:“deploy_to_prod”}

That being said, I couldn't get it to work yet -- if someone does get it to work, please share!

psilore commented 5 months ago

I got the subscription workflow to work, but in tandem with releases subscription

Kinda like this,

/github subscribe organisation/repository releases, workflows:{ name:"Production" event:"release" }

If I understand this correctly, this works because I have a workflow name: Production and it triggers on the event release

Example (removed org in screenshot): readacted_org-screenshot

However, I dont like that theres a button "Re-run all jobs" because if I send that to a slack channel just to inform, members in that channel can unintentionally and intentionally trigger workflow =( Dont know how to bypass that or remove button