integrations / slack

Bring your code to the conversations you care about with the GitHub and Slack integration
https://slack.github.com/
MIT License
3k stars 469 forks source link

subscribe to PR approvals #987

Open ghostsquad opened 4 years ago

ghostsquad commented 4 years ago

Is there anyway to show when a PR is approved?

welcome[bot] commented 4 years ago

Thanks for opening this issue! If you would like to help implement an improvement, read more about contributing and consider submitting a pull request.

tebriel commented 4 years ago

Yes, the new Scheduled Reminders beta functionality does this. Sign up for the beta preview and it will be enabled for your organization as soon as we add more to the feature flag!

don-hover commented 3 years ago

I've read the documentation for the Scheduled Reminders: https://hoverinc.atlassian.net/wiki/spaces/EPD/pages/2135883874/2021-04-12+Oauth+BE+Tech+Spec#GraphQL-response-format

I see a section that shows how to ignore Approved PRs, but I don't see anything specifically that shows how to be notified when a PR has been fully approved and is in a "Ready To Merge" state.

Screen Shot 2021-04-16 at 4 38 10 PM

Is there some part of this feature that could directly DM the PR author when their PR is approved/ready to merge?

martha-truesource commented 2 years ago

+1

I'd really like the option to be notified by Slack message when my PR is approved

pgollucci commented 2 years ago

👍

martin056 commented 2 years ago

It would be really useful if it comes out of the box from the integration :+1:

JCMais commented 2 years ago

Is there any update on this feature?

ido-hunters commented 2 years ago

This feature will really help me as well :)

jonbeacherdomuso commented 2 years ago

Please implement this feature

smacilwaine commented 2 years ago

This would be a really great feature for my company as well. I spend so much time refreshing Github just to see if my PR is merged yet, and getting notified upon approval would be much more efficient.

matiasf9 commented 2 years ago

Same here, I think it's as important as being notified when a new PR is opened.

filip-sakalos commented 2 years ago

+1

prabhushrikant commented 2 years ago

+1 for this feature. Would also like to know if new review is posted on your PR. Currently I only get notified when PR is created and merged:(

giulitn commented 2 years ago

+1

danielpatricio-wa commented 2 years ago

+1

DannyC-BC commented 2 years ago

+10000

nandastone commented 1 year ago

+1

BuddhaBing commented 1 year ago

+1

jonnywyatt commented 1 year ago

Please add this

slapart commented 1 year ago

+1

michaelignat commented 1 year ago

+1

amir-tastewise commented 1 year ago

+1

alishaevn commented 1 year ago

checking in to see if this issue has been triaged at all? I don't see it mentioned in the current road map and we cannot do it ourselves as you all are no longer accepting code contributions.

thanks!

mikemaring commented 1 year ago

Still hoping to see this

foamzou commented 1 year ago

Need the feature as well

noahtf13 commented 1 year ago

+1

deweyredman commented 1 year ago

+1

muratdozen commented 1 year ago

+1 definitely need the feature as well...

dav-pascual commented 1 year ago

+1

kelvinsanchez15 commented 1 year ago

+1

danieltharp commented 1 year ago

3 years now that GitHub is being lapped on such a basic feature by Bitbucket, sheesh. You can't fire a message to slack on a PR approval?

choladay commented 1 year ago

+1

aseerkt commented 1 year ago

+1

MilosMosovsky commented 1 year ago

+1

jacekendrick commented 11 months ago

+1

gentoomaniac commented 10 months ago

+1 right now we have a slack workflow reacting on a :heavy_check_mark: on the PR message that we manually have to add :rofl:

bernhardkaindl commented 6 months ago

+1

guglielmi-s commented 4 months ago

omg +1 :sob:

matt-theguyw1cat commented 4 months ago

+1 its actually the only thing I really want from subs

rutpshah commented 3 months ago

@gentoomaniac Can u share the workflow?

Hojland commented 2 months ago

+1

VanekPetr commented 2 months ago

+1

maxence-flowie commented 1 month ago

+100

daniddelrio commented 2 weeks ago

+1

ayoukhananov commented 3 days ago

+1