integrations / terraform-provider-github

Terraform GitHub provider
https://www.terraform.io/docs/providers/github/
MIT License
888 stars 729 forks source link

[DOCS]: github_repository_collaborator #2075

Closed sneakyjoeru closed 8 months ago

sneakyjoeru commented 8 months ago

Describe the need

Collaborator fights with teams over access level similarly to collaborators. I specifically used collaborator as it was indicated that it will not fight over rights in a way collaborators do, but it seems to not be the case. When I configured teams and multiple instances of collaborator, if those collaborator records also are in teams, terraform tries to switch their access to the one specified in a team.

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

kfcampbell commented 8 months ago

@sneakyjoeru do you mind being a bit more specific and providing a minimal reproductive case? I need a little more information to troubleshoot. Is the behavior dependent on the order the resources were applied in?

sneakyjoeru commented 8 months ago

Sure. So, you have notes in collaborators doc about it conflicting with collaborator and teams. There's no such note for conflicting with collaborators in collaborator page. Still, I have several team_repository resources which are said to conflict only with collaborators , but when I try to add a collaborator with higher rights than it's declared in team_repository, it tries to bring permissions of those collaborator records to match what's described in team_repository.

TLDR trying to elevate permissions for "collaborator" which is already listed in "team_repository" with lower level.

I hope it makes sense?

sneakyjoeru commented 8 months ago

Cancel that. I've made a mistake with how rules are executed. Apologies for that.

kfcampbell commented 8 months ago

@sneakyjoeru No worries, thank you for caring enough to open an issue and talk through it.