fix: Remove invalid update of create_default_maintainer from import github_team_members

richjyoung commented 7 months ago

Fixes bug where it is not possible to run terraform import against github_team_members resources in v6.0.0-beta.

Resolves #2124

Before the change?

github_team_members import reused the schema.ResourceImporter definition in resourceGithubTeamImport, which also defaults create_default_maintainer to false. create_default_maintainer is not part of the github_team_members schema so this fails the command with an error.

After the change?

Separated the import definitions and added a new function for github_team_members as resourceGithubTeamMembersImport, with the same getTeamID... based mapping.

Pull request checklist

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

[ ] Yes
[x] No

kfcampbell commented 7 months ago

@richjyoung this should be targeted at the v6 branch instead of main, right?

richjyoung commented 7 months ago

Sorry yes, have updated. It does look like the behaviour is unchanged from 5.45.0 though. This PR is the change I had to make to get the import to work properly in my local state so I can't say why this now causes the linked issue.

integrations / terraform-provider-github