fix(resource_github_repository): Create repo from template with visibility to avoid org policy issue - Githubissues

integrations / terraform-provider-github

Terraform GitHub provider

https://www.terraform.io/docs/providers/github/

MIT License

886 stars 726 forks source link

fix(resource_github_repository): Create repo from template with visibility to avoid org policy issue #2151

Closed littlelionking closed 1 month ago

littlelionking commented 6 months ago

Resolves #925

Before the change?

When creating a repository from a template, it sets the visibility to either public or private according to this bool:

Private:            github.Bool(isPrivate),

And then edits the repo settings later to ensure the visibility is correct.

After the change?

Now it sets the Visibility parameter instead, allowing "internal" as an option.

Pull request checklist

[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

[x] No

littlelionking commented 3 months ago

Hi @kfcampbell / @nickfloyd would I be able to get your thoughts on this?