integrations / terraform-provider-github

Terraform GitHub provider
https://www.terraform.io/docs/providers/github/
MIT License
886 stars 726 forks source link

[BUG]: rest api swallows all errors (in order to allow for 404's) #2156

Closed riezebosch closed 6 months ago

riezebosch commented 6 months ago

Expected Behavior

currently decode of json fails for certain response types, but since all exceptions that come out of the rest client are ignored there's just null stored in state.

Actual Behavior

check explicitly for the response status (in case you want allow 404 as expected behaviour).

Terraform Version

v6.0.0

Affected Resource(s)

Terraform Configuration Files

No response

Steps to Reproduce

No response

Debug Output

No response

Panic Output

No response

Code of Conduct