chore(actions_runner_group): fix missing schema id

EttoreFoti commented 5 months ago

Resolves #2162

Before the change?

The provider would fail to create github_actions_runner_group due to broken schema, it would create the resource but causes terraform to fail.

After the change?

The provider correctly creates the broken resource.

Pull request checklist

[-] Tests for the changes have been added (for bug fixes / features)
[-] Docs have been reviewed and added / updated if needed (for bug fixes / features) Both checks are not needed as the functionality as not been changed.

TF Acceptance Test output

❯ TF_ACC=1 go test -v ./... -run ^TestAccGithubActionsRunnerGroup ? github.com/integrations/terraform-provider-github/v6 [no test files] === RUN TestAccGithubActionsRunnerGroup === RUN TestAccGithubActionsRunnerGroup/creates_runner_groups_without_error === RUN TestAccGithubActionsRunnerGroup/creates_runner_groups_without_error/with_an_anonymous_account resource_github_actions_runner_group_test.go:118: anonymous account not supported for this operation === RUN TestAccGithubActionsRunnerGroup/creates_runner_groups_without_error/with_an_individual_account resource_github_actions_runner_group_test.go:122: individual account not supported for this operation === RUN TestAccGithubActionsRunnerGroup/creates_runner_groups_without_error/with_an_organization_account === RUN TestAccGithubActionsRunnerGroup/manages_runner_visibility === RUN TestAccGithubActionsRunnerGroup/manages_runner_visibility/with_an_anonymous_account resource_github_actions_runner_group_test.go:182: anonymous account not supported for this operation === RUN TestAccGithubActionsRunnerGroup/manages_runner_visibility/with_an_individual_account resource_github_actions_runner_group_test.go:186: individual account not supported for this operation === RUN TestAccGithubActionsRunnerGroup/manages_runner_visibility/with_an_organization_account === RUN TestAccGithubActionsRunnerGroup/imports_an_all_runner_group_without_error === RUN TestAccGithubActionsRunnerGroup/imports_an_all_runner_group_without_error/with_an_anonymous_account resource_github_actions_runner_group_test.go:233: anonymous account not supported for this operation === RUN TestAccGithubActionsRunnerGroup/imports_an_all_runner_group_without_error/with_an_individual_account resource_github_actions_runner_group_test.go:237: individual account not supported for this operation === RUN TestAccGithubActionsRunnerGroup/imports_an_all_runner_group_without_error/with_an_organization_account === RUN TestAccGithubActionsRunnerGroup/imports_a_private_runner_group_without_error === RUN TestAccGithubActionsRunnerGroup/imports_a_private_runner_group_without_error/with_an_anonymous_account resource_github_actions_runner_group_test.go:283: anonymous account not supported for this operation === RUN TestAccGithubActionsRunnerGroup/imports_a_private_runner_group_without_error/with_an_individual_account resource_github_actions_runner_group_test.go:287: individual account not supported for this operation === RUN TestAccGithubActionsRunnerGroup/imports_a_private_runner_group_without_error/with_an_organization_account resource_github_actions_runner_group_test.go:294: always shows a diff for visibility 'all' => 'private' === RUN TestAccGithubActionsRunnerGroup/imports_a_selected_runner_group_without_error === RUN TestAccGithubActionsRunnerGroup/imports_a_selected_runner_group_without_error/with_an_individual_account provider_utils.go:64: GITHUB_TOKEN and GITHUB_OWNER environment variables should be set provider_utils.go:74: Skipping TestAccGithubActionsRunnerGroup/imports_a_selected_runner_group_without_error/with_an_individual_account which requires individual mode === RUN TestAccGithubActionsRunnerGroup/imports_a_selected_runner_group_without_error/with_an_organization_account --- PASS: TestAccGithubActionsRunnerGroup (94.77s) --- PASS: TestAccGithubActionsRunnerGroup/creates_runner_groups_without_error (33.11s) --- SKIP: TestAccGithubActionsRunnerGroup/creates_runner_groups_without_error/with_an_anonymous_account (0.00s) --- SKIP: TestAccGithubActionsRunnerGroup/creates_runner_groups_without_error/with_an_individual_account (0.00s) --- PASS: TestAccGithubActionsRunnerGroup/creates_runner_groups_without_error/with_an_organization_account (33.11s) --- PASS: TestAccGithubActionsRunnerGroup/manages_runner_visibility (18.40s) --- SKIP: TestAccGithubActionsRunnerGroup/manages_runner_visibility/with_an_anonymous_account (0.00s) --- SKIP: TestAccGithubActionsRunnerGroup/manages_runner_visibility/with_an_individual_account (0.00s) --- PASS: TestAccGithubActionsRunnerGroup/manages_runner_visibility/with_an_organization_account (18.40s) --- PASS: TestAccGithubActionsRunnerGroup/imports_an_all_runner_group_without_error (21.62s) --- SKIP: TestAccGithubActionsRunnerGroup/imports_an_all_runner_group_without_error/with_an_anonymous_account (0.00s) --- SKIP: TestAccGithubActionsRunnerGroup/imports_an_all_runner_group_without_error/with_an_individual_account (0.00s) --- PASS: TestAccGithubActionsRunnerGroup/imports_an_all_runner_group_without_error/with_an_organization_account (21.62s) --- PASS: TestAccGithubActionsRunnerGroup/imports_a_private_runner_group_without_error (0.00s) --- SKIP: TestAccGithubActionsRunnerGroup/imports_a_private_runner_group_without_error/with_an_anonymous_account (0.00s) --- SKIP: TestAccGithubActionsRunnerGroup/imports_a_private_runner_group_without_error/with_an_individual_account (0.00s) --- SKIP: TestAccGithubActionsRunnerGroup/imports_a_private_runner_group_without_error/with_an_organization_account (0.00s) --- PASS: TestAccGithubActionsRunnerGroup/imports_a_selected_runner_group_without_error (21.64s) --- SKIP: TestAccGithubActionsRunnerGroup/imports_a_selected_runner_group_without_error/with_an_individual_account (0.00s) --- PASS: TestAccGithubActionsRunnerGroup/imports_a_selected_runner_group_without_error/with_an_organization_account (21.64s) PASS ok github.com/integrations/terraform-provider-github/v6/github 95.202s

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

[ ] Yes
[X] No

bradam12 commented 5 months ago

I'm running into this issue now. Tested this PR locally and can confirm it fixes the issue and tests pass.

@kfcampbell

gm-hyp-2 commented 5 months ago

@kfcampbell hello! Can you please review and release if it is from your side?

EttoreFoti commented 4 months ago

@kfcampbell any update on this?

integrations / terraform-provider-github