chore(organization_webhook): fix insecure_ssl

EttoreFoti commented 5 months ago

Resolves #2142

Before the change?

The Provider was missing the conversion step causing type mismatch for go.

After the change?

The Provider does the correct parsing of the input.

Pull request checklist

[-] Tests for the changes have been added (for bug fixes / features)
[-] Docs have been reviewed and added / updated if needed (for bug fixes / features) Both are not needed since it's just a fix over already existing resource.

Does this introduce a breaking change?

[ ] Yes
[X] No

kfcampbell commented 5 months ago

@EttoreFoti can you describe (and perhaps include output from) the testing process you used here, since integration tests aren't added?

EttoreFoti commented 5 months ago

@EttoreFoti can you describe (and perhaps include output from) the testing process you used here, since integration tests aren't added?

Just run the current AcceptanceTest that was previously failing, I can copy paste output if needed.

gm-hyp-2 commented 5 months ago

@kfcampbell hello! Can you please review and release if it is all ok? thanks!

EttoreFoti commented 4 months ago

@kfcampbell any update on this?

kfcampbell commented 4 months ago

The test used to panic for me and now it's failing. I'm seeing the following output:

--- FAIL: TestAccGithubOrganizationWebhook (17.29s)
    --- FAIL: TestAccGithubOrganizationWebhook/creates_and_updates_webhooks_without_error (7.06s)
        --- SKIP: TestAccGithubOrganizationWebhook/creates_and_updates_webhooks_without_error/with_an_anonymous_account (0.00s)
        --- SKIP: TestAccGithubOrganizationWebhook/creates_and_updates_webhooks_without_error/with_an_individual_account (0.00s)
        --- FAIL: TestAccGithubOrganizationWebhook/creates_and_updates_webhooks_without_error/with_an_organization_account (7.06s)
    --- PASS: TestAccGithubOrganizationWebhook/imports_webhooks_without_error (10.23s)
        --- SKIP: TestAccGithubOrganizationWebhook/imports_webhooks_without_error/with_an_anonymous_account (0.00s)
        --- SKIP: TestAccGithubOrganizationWebhook/imports_webhooks_without_error/with_an_individual_account (0.00s)
        --- PASS: TestAccGithubOrganizationWebhook/imports_webhooks_without_error/with_an_organization_account (10.23s)
FAIL

The specific error is:

    resource_github_organization_webhook_test.go:53: Step 1/2 error: Error running apply: exit status 1

        Error: POST https://api.github.com/orgs/kfcampbell-terraform-provider/hooks: 422 Validation Failed [{Resource:Hook Field: Code:custom Message:Hook already exists on this organization}]

          with github_organization_webhook.test,
          on terraform_plugin_test.tf line 9, in resource "github_organization_webhook" "test":
           9:           resource "github_organization_webhook" "test" {

but that's possibly related to the org I'm using for testing and/or a dirty integration test setup. Does it pass cleanly now for you?

integrations / terraform-provider-github