integrations / terraform-provider-github

Terraform GitHub provider
https://www.terraform.io/docs/providers/github/
MIT License
879 stars 719 forks source link

Feat: Fixes abandoned PR #2017: Add support for the require_last_push_approval flag in github_branch_protection_v3 #2199

Closed georgekaz closed 5 months ago

georgekaz commented 5 months ago

Resolves #1723 and the bug left in PR #2017

Only the last commit on this is mine, to resolve this problem on a PR created by matthewcostatide


Before the change?

The github_branch_protection_v3 resource doesn't support setting the require_last_push_approval flag, and its presence is omitted from the documentation.

After the change?

This PR adds support for the require_last_push_approval flag in the required_pull_request_reviews block of the github_branch_protection_v3 resource type, consistent with the github_branch_protection resource.

Pull request checklist

Does this introduce a breaking change?

Please see our docs on breaking changes to help!


aalvarezaph commented 5 months ago

Thanks @matthewcostatide !