integrations / terraform-provider-github

Terraform GitHub provider
https://www.terraform.io/docs/providers/github/
MIT License
879 stars 719 forks source link

[BUG]: repository_ruleset resource not updating when rules.pull_request change #2203

Open dominikkeil-tqgg opened 5 months ago

dominikkeil-tqgg commented 5 months ago

Expected Behavior

adding require_code_owner_review = true to an existing repository_ruleset resource will update existing rulesets to reflect the change****

Actual Behavior

adding require_code_owner_review = true to an existing repository_ruleset does not cause the resource to be updated

Terraform Version

Terraform v1.7.2 on linux_amd64

Affected Resource(s)

Terraform Configuration Files

resource "github_repository_ruleset" "this" {
  depends_on  = [github_repository.this]
  name        = "main"
  repository  = var.name
  target      = "branch"
  enforcement = "active"

  conditions {
    ref_name {
      include = ["~DEFAULT_BRANCH"]
      exclude = []
    }
  }

  rules {
    creation = true
    update   = false
    deletion = true

    non_fast_forward        = true
    required_linear_history = false

    pull_request {
      require_code_owner_review         = true
      dismiss_stale_reviews_on_push     = true
      require_last_push_approval        = true
      required_approving_review_count   = 1
      required_review_thread_resolution = true
    }
  }

  # allow repo admins to bypass entire rule
  bypass_actors {
    bypass_mode = "always"
    actor_id    = 5
    actor_type  = "RepositoryRole"
  }

  # allow repo maintainers to bypass pr rule
  bypass_actors {
    bypass_mode = "pull_request"
    actor_id    = 2
    actor_type  = "RepositoryRole"
  }

  lifecycle {
    ignore_changes = [rules["required_status_checks"]]
  }
}

Steps to Reproduce

No response

Debug Output

No response

Panic Output

No response

Code of Conduct