Open bzarboni1 opened 6 months ago
Thanks for the contribution! The newly-added test is failing for me:
--- FAIL: TestAccGithubRepositoryWebCommitSignoffRequired (11.15s)
--- FAIL: TestAccGithubRepositoryWebCommitSignoffRequired/changes_the_web_commit_signoff_required_attribute_for_a_repository (5.67s)
--- SKIP: TestAccGithubRepositoryWebCommitSignoffRequired/changes_the_web_commit_signoff_required_attribute_for_a_repository/with_an_anonymous_account (0.00s)
--- FAIL: TestAccGithubRepositoryWebCommitSignoffRequired/changes_the_web_commit_signoff_required_attribute_for_a_repository/with_an_individual_account (5.67s)
--- SKIP: TestAccGithubRepositoryWebCommitSignoffRequired/changes_the_web_commit_signoff_required_attribute_for_a_repository/with_an_organization_account (0.00s)
--- FAIL: TestAccGithubRepositoryWebCommitSignoffRequired/changes_a_non_web_commit_signoff_required_attribute_for_a_repository (5.49s)
--- SKIP: TestAccGithubRepositoryWebCommitSignoffRequired/changes_a_non_web_commit_signoff_required_attribute_for_a_repository/with_an_anonymous_account (0.00s)
--- FAIL: TestAccGithubRepositoryWebCommitSignoffRequired/changes_a_non_web_commit_signoff_required_attribute_for_a_repository/with_an_individual_account (5.49s)
--- SKIP: TestAccGithubRepositoryWebCommitSignoffRequired/changes_a_non_web_commit_signoff_required_attribute_for_a_repository/with_an_organization_account (0.00s)
FAIL
with the following error:
resource_github_repository_test.go:1648: Step 1/2 error: After applying this test step, the plan was not empty.
stdout:
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# github_repository.test will be updated in-place
~ resource "github_repository" "test" {
id = "tf-acc-4apm1"
name = "tf-acc-4apm1"
- vulnerability_alerts = true -> null
# (32 unchanged attributes hidden)
# (1 unchanged block hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
Is this something you can reproduce?
Thanks for the contribution! The newly-added test is failing for me:
--- FAIL: TestAccGithubRepositoryWebCommitSignoffRequired (11.15s) --- FAIL: TestAccGithubRepositoryWebCommitSignoffRequired/changes_the_web_commit_signoff_required_attribute_for_a_repository (5.67s) --- SKIP: TestAccGithubRepositoryWebCommitSignoffRequired/changes_the_web_commit_signoff_required_attribute_for_a_repository/with_an_anonymous_account (0.00s) --- FAIL: TestAccGithubRepositoryWebCommitSignoffRequired/changes_the_web_commit_signoff_required_attribute_for_a_repository/with_an_individual_account (5.67s) --- SKIP: TestAccGithubRepositoryWebCommitSignoffRequired/changes_the_web_commit_signoff_required_attribute_for_a_repository/with_an_organization_account (0.00s) --- FAIL: TestAccGithubRepositoryWebCommitSignoffRequired/changes_a_non_web_commit_signoff_required_attribute_for_a_repository (5.49s) --- SKIP: TestAccGithubRepositoryWebCommitSignoffRequired/changes_a_non_web_commit_signoff_required_attribute_for_a_repository/with_an_anonymous_account (0.00s) --- FAIL: TestAccGithubRepositoryWebCommitSignoffRequired/changes_a_non_web_commit_signoff_required_attribute_for_a_repository/with_an_individual_account (5.49s) --- SKIP: TestAccGithubRepositoryWebCommitSignoffRequired/changes_a_non_web_commit_signoff_required_attribute_for_a_repository/with_an_organization_account (0.00s) FAIL
with the following error:
resource_github_repository_test.go:1648: Step 1/2 error: After applying this test step, the plan was not empty. stdout: Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols: ~ update in-place Terraform will perform the following actions: # github_repository.test will be updated in-place ~ resource "github_repository" "test" { id = "tf-acc-4apm1" name = "tf-acc-4apm1" - vulnerability_alerts = true -> null # (32 unchanged attributes hidden) # (1 unchanged block hidden) } Plan: 0 to add, 1 to change, 0 to destroy.
Is this something you can reproduce?
Apologies for the late reply. I've tried it here on my end, and had a colleague try as well. The test are successful for us.
Bump
Resolves #I2077
Before the change?
repository
update, there's a bug in the GitHub 2022-11-28 version, that throws a 422 error whenever theweb_commit_signoff_required
is set to true, even when it is already true.After the change?
web_commit_signoff_required
has been modified. If it has, it is passed along in the request. If it hasn't, it is silently dropped from the request.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!