integrations / terraform-provider-github

Terraform GitHub provider
https://www.terraform.io/docs/providers/github/
MIT License
891 stars 736 forks source link

fix(branch_protection_v3): ignore context when value exists in checks #2232

Open jporzucek opened 5 months ago

jporzucek commented 5 months ago

Resolves #1701

Before the change?

github_branch_protection_v3 flattens all contexts even if they're only configured in checks and if contexts field is empty in required_status_checks.

After the change?

If the context is already in checks, it's not parsed into context field.

Pull request checklist

Does this introduce a breaking change?

It doesn't break anything since contexts in checks are still applied and they'll be applied by GitHub to contexts.


bahag-hammera commented 4 months ago

@jporzucek Is there an Update on this PR we are waiting heavily on this fix :) @kfcampbell

jporzucek commented 4 months ago

@kfcampbell Can you take a look at this PR when you have a chance pls? 🙏