fix: Fixing `enterprise_id` import on `github_enterprise_actions_permissions`

ErikElkins commented 1 month ago

Resolves issue where enterprise_id wasn't getting imported as mentioned here: https://github.com/integrations/terraform-provider-github/pull/2155#issuecomment-1993599613

Before the change?

The enterprise_id field wasn't getting set in state as a part of the import process of the github_enterprise_actions_permissions resource. Also, github/resource_github_enterprise_actions_runner_group_test.go was misspelled.

After the change?

The github_enterprise_actions_permissions now uses the enterprise_slug field to align with resource_github_enterprise_actions_runner_group and other enterprise resources, and sets it as a part of the import process.

Pull request checklist

[X] Tests for the changes have been added (for bug fixes / features)
[X] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

[X] Yes
[ ] No

kfcampbell commented 1 month ago

@ErikElkins thanks for the contribution! I'm torn about the breaking change here -- since the behavior was broken in the first place, I wonder if it's okay to release the schema change without a corresponding major version bump, since Hashicorp is pretty clear that releasing major versions too frequently is a bad idea: "To allow practitioners sufficient time and opportunity to upgrade to the latest version of the provider, we recommend releasing major versions no more than once per year. Releasing major versions more frequently could present a barrier to adoption due to the effort required to upgrade."

What do you think?

ErikElkins commented 1 month ago

Yeah I think it's fair to avoid the major version change. It's probably only me and the one other commenter using this resource right now.

integrations / terraform-provider-github