fix(etag): fix etag being noisy when no actual state has been changed

[aamkye]

Resolves:

• https://github.com/integrations/terraform-provider-github/issues/796
• https://github.com/integrations/terraform-provider-github/issues/910
• https://github.com/hashicorp/terraform/issues/28803
• https://github.com/integrations/terraform-provider-github/pull/911
• https://github.com/integrations/terraform-provider-github/pull/909

---

Before the change?

• ETag are shown in diff on almost every plan, even after apply just before the next plan.

After the change?

• ETag is hidden from output.

Pull request checklist

• [x] Tests for the changes have been added (for bug fixes / features)
• [x] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

• [ ] Yes
• [x] No

---

Disclaimer - I made the change according to my needs, please let me know if this should be extended to all/other resources.

[aamkye]

@kfcampbell could you look at this? :)

[kfcampbell]

@aamkye I can't accept a PR that modifies a vendored file, sorry. That would just be overwritten the next time dependencies are updated. I agree that this issue is super annoying but maybe we can find a more durable way around it.

[aamkye]

@kfcampbell, so if I understood correctly, first I need to make a change in vendor file but within vendor repo (https://github.com/hashicorp/terraform-plugin-sdk), and then adjust suppression functions?