fix(RateLimitRoundtripper): Fix mutex leak and not respecting context cancellation - Githubissues

integrations / terraform-provider-github

Terraform GitHub provider

https://www.terraform.io/docs/providers/github/

MIT License

863 stars 708 forks source link

fix(RateLimitRoundtripper): Fix mutex leak and not respecting context cancellation #2298

Open pete-woods opened 1 week ago

pete-woods commented 1 week ago

Resolves #2299

Before the change?

Cancellation is not being respected in the transport's sleeps.
Additionally, there's a path out of the function that does not unlock the mutex.

After the change?

Cancellation is now respected, and the mutex always unlocks.

Pull request checklist

[x] Tests for the changes have been added (for bug fixes / features)
~[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)~

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

[ ] Yes
[x] No