onurg
commented
3 years ago just hit the same issue on a terratest run:
- we're creating a dummy repo with visibility set to private
- we apply, test and destroy
- on destroy it fails
TestRepositoryValidity 2021-01-25T19:58:34Z logger.go:66: module.repositories["repositories/test-dummy-repo-1"].github_branch_default.default_branch: Destroying... [id=test-dummy-repo-1]
TestRepositoryValidity 2021-01-25T19:58:35Z logger.go:66:
TestRepositoryValidity 2021-01-25T19:58:35Z logger.go:66: Error: PATCH https://api.github.com/repos/xxxx/test-dummy-repo-1: 422 Visibility is already private. []
TestRepositoryValidity 2021-01-25T19:58:35Z logger.go:66:
TestRepositoryValidity 2021-01-25T19:58:35Z logger.go:66:
TestRepositoryValidity 2021-01-25T19:58:35Z retry.go:80: Returning due to fatal error: FatalError{Underlying: error while running command: exit status 1;
Error: PATCH https://api.github.com/repos/xxxx/test-dummy-repo-1: 422 Visibility is already private. []
}
destroy.go:11:
Error Trace: destroy.go:11
terratest.go:56
tests_test.go:50
Error: Received unexpected error:
FatalError{Underlying: error while running command: exit status 1;
Error: PATCH https://api.github.com/repos/xxxx/test-dummy-repo-1: 422 Visibility is already private. []
}
jcudit
I've found an issue that seems to crop up on repo deletion. The issue appears to be with private repos that have a `` resource set.
Terraform Version
This issue is reproducible on the latest versions. (as of today; 2020-12-04)
Affected Resource(s)
Terraform Configuration Files
Here is a simple test-case that is identical to the test case I used to find/document this bug. I have stripped out org/personal information and substituted generic tokens in place:
Debug Output
Please provide a link to a GitHub Gist containing the complete debug output: https://www.terraform.io/docs/internals/debugging.html. Please do NOT paste the debug output in the issue; just paste a link to the Gist.
Here is a short version:
Note: I get the same result if I comment out only the
github_branch_defaultresource and then run a normalterraform apply. I just used--targetto hone which resource caused the error.I am more than happy to provide the full
TF_LOG=TRACEoutput, but it's 3K lines long with the--targetflag. I've included the relevant bits below:Panic Output
No panic produced.
Expected Behavior
I would expect the default branch configuration to be deleted w/o the
422API error.Actual Behavior
I get this error returned from GH API:
Steps to Reproduce
(see
note2below) comment out thegithub_branch_defaultresource in the above 'test case' configuration.run
tf applyagainst the config and observe that 4 resources are created, one of which is the repo.un-comment out the
github_branch_defaultresource in the above 'test-case' config.use either the web UI or
git checkout -b && git pushto make the branch calledMyNonMainDefaultBranchin the new reporun
tf applyagainst the config and observe that one new resource will be createddetermine that the repo and associated resources created in the test config must now be deleted
comment out all the resources in the above test case
run
tf applyagainst the config and observe that 5 resources will be destroyedobserve that some resources have been deleted:
(see
note1below). Manually remove thegithub_branch_defaultresource from the state filerun
tf applyagainst the config and observe that the remaining resource (thegithub_repository.myOrg_testing) will be destroyedNote1:: If, instead of manually removing the
github_branch_defaultresource from the state file as in step 10, you leave ONLY thegithub_repositoryresource un-commented, terraform will still only destroy thegithub_branch_default.myOrg_testingresource. This tells me that the dependency resolution is logically correct but inefficient/un-optimized; the deletion of thegithub_branch_defaultdoes not matter if thegithub_repositoryis to be deleted. Deleting the repo necessarily deletes the default branch config.Note2: Failure to comment out the
github_branch_defaultresource in step 1 will result in an error:Important Factoids
I can reproduce this behavior with the token that was allocated specifically for our automated Terraform ci/cd pipeline and with my personal token which has 'Owner' level permissions attached to it.
The workaround is to:
comment out / delete the
github_branch_defaultresource from the*.tffile(s).manually remove the
github_branch_defaultresource from the state file:terraform state rm github_branch_default.myOrg_testing:terraform applyand let it observe that thegithub_repositoryis missing and thus should be deleted. Deleting the repo necessarily deletes the repos' default branch config.References
These issues seem related:
https://github.com/terraform-providers/terraform-provider-github/issues/580