search

integrations / terraform-provider-github

Terraform GitHub provider
https://www.terraform.io/docs/providers/github/
MIT License
905 stars 744 forks source link

oauth app creation resource for github #786

Open sharmavijay86 opened 3 years ago

sharmavijay86 commented 3 years ago

Hey there, We are working on some frontend react integrations with terraform code. Where in we want to provision application and then create on github oauth application. All above is with terraform. So that now we can incorporate this oauth details with application to make everything automated, from oauth app creation to web app creation to its integration etc.

I don't see the resource type in documentation, so any way around.??

jcudit commented 3 years ago

Seems like we'd need a new resource to satisfy your use case. We currently do not have a way to create apps via the provider.

Kampe commented 3 years ago

Would love this as well, this is one of the last things we need to automate within github.

mike-kaminski commented 3 years ago

This would be great to implement inline w/ the https://docs.github.com/en/rest/reference/apps#create-a-github-app-from-a-manifest API functionality.

kory33 commented 2 years ago

We also have an use-case where an automatic creation of OAuth Apps comes handy as we are trying to declare everything in our infrastructure.

I am happy to work on this issue. However, what @mike-kaminski has suggested above

This would be great to implement inline w/ the https://docs.github.com/en/rest/reference/apps#create-a-github-app-from-a-manifest API functionality.

only works for a GitHub App creation. While I am also interested in creating GitHub Apps automatically (I might open another issue for this), IIUC the manifest API cannot solve the original problem in this issue.

Moreover, I could not find a feature both in go-github library nor in the official GitHub REST API to create an OAuth App directly. At the current time this looks like an upstream issue, but any other thoughts on this?

riuvshyn commented 2 years ago

also looking forward to this

ClaytonOlleyNutrien commented 2 years ago

I'd love to see this implemented as well!

gthieleb commented 1 year ago

Any news on that? I would like to have this implemented to create rancher clusters with terraform where user can authenticate via github. Is the go-api a showstopper here?

kfcampbell commented 1 year ago

It's currently waiting on upstream support. We would need this feature available in the GitHub API before we could work on it at the Terraform provider level.

lewismiddleton commented 8 months ago

It's currently waiting on upstream support. We would need this feature available in the GitHub API before we could work on it at the Terraform provider level.

Is this supported by https://github.com/google/go-github/pull/1335 or is there more functionality needed?