search

integritee-network / pallets

Other
10 stars 14 forks source link

Pr polkadot v0.9.32 #121

Closed BillyWooo closed 1 year ago

BillyWooo commented 1 year ago

upgrade to substrate: polkadot-v0.9.32

clangenb commented 1 year ago

Hmm, it seems that parity has included a new dependency that is plain GPL-3, how do you suggest we handle this @Niederb?

Can we still be Apache-2? If not, parity can't either, I suppose - haha. I would imagine that parity is simply not aware of this.

haerdib commented 1 year ago

FYI : https://github.com/paritytech/substrate/issues/12689

haerdib commented 1 year ago

There's already a new version of array-bytes.. So maybe a patch would solve this problem?

Niederb commented 1 year ago

@haerdib You are quick 😄 @clangenb Seems that this one is already reported but yeah if our main dependency is not strict with the licensing then there will always be issues popping up. Our options are quite limited:

clangenb commented 1 year ago

Patching does not work, you can only patch the same version. As this will be fixed in a future release, I simply suggest to accept the licence violation for now.

haerdib commented 1 year ago

There's an even simpler solution, I believe: @BillyWooo can you try to run cargo update -p array-bytes ? That should update it to 4.2, which already includes Apache 2.0 license.

Tested it on the substrate-api-client.

BillyWooo commented 1 year ago

cargo update -p array-bytes

Just commit new changes from cargo update -p array-bytes