search

integritee-network / pallets

Other
10 stars 14 forks source link

Xcm Transactor for Swapping lease slots #122

Closed coax1d closed 1 year ago

coax1d commented 1 year ago

Extendable Xcm Transactor which initially supports sending a UMP message to the Relay chain to call 'Registrar::swap'. This is necessary for swapping lease slots between the shell-runtime and Integritee runtime on Kusama.

coax1d commented 1 year ago

@clangenb @OverOrion The CI might be having some issues with licensing due to xcm and some other polkadot related procedural macros. Also need to talk a bit about weights on the extrinsic and what is necessary and what is not. lmk what you think so far.

clangenb commented 1 year ago

@clangenb @OverOrion The CI might be having some issues with licensing due to xcm and some other polkadot related procedural macros.

Ah I see, yeah the issue is with Polkadot's (GPL-3.0-only) licence. Hmm, this is kind of a bummer, to my understanding we need to use the less permissive GPL3 licences for at your XCM crates, do you agree @Niederb?

clangenb commented 1 year ago

All in all this seems very complete to me! But good point with the benchmark, I would have missed that! I think we should do a proper benchmarking setup considering that this pallet has come to stay :)

Niederb commented 1 year ago

@clangenb @OverOrion The CI might be having some issues with licensing due to xcm and some other polkadot related procedural macros.

Ah I see, yeah the issue is with Polkadot's (GPL-3.0-only) licence. Hmm, this is kind of a bummer, to my understanding we need to use the less permissive GPL3 licences for at your XCM crates, do you agree @Niederb?

@clangenb I agree. I think the polkadot repository is under GPL-3 and if we use it we don't have much choice...

coax1d commented 1 year ago

@clangenb What should be done about the license check failure?

clangenb commented 1 year ago

@clangenb What should be done about the license check failure?

We have to add it to the about.toml and then we also have to change the licence of your new crate to the same licence.