search

integritee-network / pallets

Other
10 stars 14 forks source link

use core:: instead of std:: for mem::size_of #141

Closed OverOrion closed 1 year ago

OverOrion commented 1 year ago

std is not available, core should be used.

OverOrion commented 1 year ago

I am confused, has this ever been compiled in a node? @Niederb How has this been unnoticed?

The fault is mine I suggested it in a review comment :cry: .

Niederb commented 1 year ago

Yeah it is quite embarrassing. It was introduced quite recently during the review phase. Apparently I did not check again inside the node 😞

clangenb commented 1 year ago

No worries, can happen. I was wondering how you guys tested :D