Mistmatching WeightInfo for pallet_teerex

integritee-network / pallets

Other

10 stars 14 forks source link

Mistmatching WeightInfo for pallet_teerex #156

Closed Kailai-Wang closed 1 year ago

Kailai-Wang commented 1 year ago

I assume the weights.rs for pallet_teerex (and maybe other pallets) hasn't been updated for a long time, we tried to run a runtime benchmarking for these pallets and discovered a few problems:

<T as Config>::WeightInfo::publish_hash() expects two parameters but none is provided in the trait
register_dcap_enclave and register_quoting_enclave are missing in the benchmarks

This is our generated runtime weights file for pallet-teerex using upstream benchmarking.rs

clangenb commented 1 year ago

The one with the DCAP attestations is know, we have for now put in conservative values just to ensure that no-one can attack the chain. We have an open issue for that: https://github.com/integritee-network/pallets/issues/125

I did create a benchmark and have also run it in the tests for the publish_hash (I thought that I also run it in the node, but maybe I forgot). Thanks for the notice!