search

integritee-network / pallets

Other
10 stars 14 forks source link

Should the enclave be generic over URL? #190

Open clangenb opened 1 year ago

clangenb commented 1 year ago

If I remember this correctly, we did this because we can't use Strings inside the runtime, but I am not sure if this is the right approach. Maybe we can just use PalletString as we use elsewhere: https://github.com/integritee-network/pallets/blob/be26e6b85f14896860ef919488e6bb4cf4b7aa29/primitives/common/src/lib.rs#L27

brenzi commented 1 year ago

It shouldn't. I think we can define a safe bounded length for the url and use PalletString with BoundedVec

but I'd like the length of the bounded PalletString to be configurable by type argument. This might make sense to solve together with #155 bounded types

clangenb commented 1 year ago

Alright, makes sense to me.