integritysystemscompany / animal_schema

Collaborative definition of JSON Schema to support individual animal data exchange. Builds on ICAR standard and focuses on Australian red meat needs.
6 stars 6 forks source link

treatments: remove date from Dose #27

Closed Traksewt closed 4 years ago

Traksewt commented 4 years ago

Treatment has date applied as part of its core event. The Dose can refer to an amount (with units) without needing the provide date again.

Traksewt commented 4 years ago

Maybe Dose is collapsed into Treatment, or Dose is renamed to represent a value with a unit (Measurement). This dose in its current form seems inconsistent with how we discussed weight and embedded objects.

cookeac commented 4 years ago

Yes, date should have been removed from Dose prior to publishing the draft.

anitanagaraj commented 4 years ago

Updated.

Traksewt commented 4 years ago

Good though now Dose Type seems like a generic object of Measurement. If so, this can be reused for weight too.