search

integritysystemscompany / animal_schema

Collaborative definition of JSON Schema to support individual animal data exchange. Builds on ICAR standard and focuses on Australian red meat needs.
6 stars 6 forks source link

Movement: Person: licence credential isn't specific enough #51

Closed sejast closed 4 years ago

sejast commented 4 years ago

licenseCredential feels like it should be an array and that each value should have a schema of license type and license number

cookeac commented 4 years ago

@anitanagaraj we decided that we would implement credentials as described above

licenceCredentials: array of [iscLicenceCredentialType] where iscLicenceCredentialType: allof icarIdentifierType

anitanagaraj commented 4 years ago

This has been implemented in the spreadsheet and json files

anitanagaraj commented 4 years ago

@AndyDe-Aldent , updated in the spreadsheet

AndyDe-Aldent commented 4 years ago

Created the iscLicenceCredentialType file and changed the licenceCredentials field to be of that type. @anitanagaraj spreadsheet has both "licence" and "license" spellings. I have set the files to match the spreadsheet but should this be singled down to one spelling?

anitanagaraj commented 4 years ago

@AndyDe-Aldent , have changed it to licence with a 'c', which I guess should be used for the noun form.

cookeac commented 4 years ago

Updated and simplified - does not need duplicate fields as base icarIdentifierType already has scheme and id.