integritysystemscompany / animal_schema

Collaborative definition of JSON Schema to support individual animal data exchange. Builds on ICAR standard and focuses on Australian red meat needs.
6 stars 6 forks source link

Weigh - Measurement object #9

Closed sejast closed 4 years ago

sejast commented 4 years ago

Is it worth using types to encapsulate the values in an observation?

The example in score would be a weight wrapping value, units and resolution.

anitanagaraj commented 4 years ago

It is good idea if we think we will use these measurement types frequently.

cookeac commented 4 years ago

We are leaning towards creating the following to support various measurements (See also issue #31): iscMeasurementType - defines value, resolution iscMassMeasurementType - adds units for mass iscVolumeMeasurementType - defines units for volume iscDistanceMeasurementType - defines units for distance or length This allows the enumerations of units to be specific, which will aid developers in developing appropriate mappings from their internal data to UN/CEFACT units.

Thus in a weight event... "weight": { "$ref": "iscMassMeasurementType" }

We discussed doing the same with Dose (for medicines), but it has a specific set of units relevant to medicines, drenches, and related treatments, rather than a general mass unit. Resolution is also less useful for Dose.

cookeac commented 4 years ago

Defined iscMeasurementType.json and iscMassMeasurementType.json. Changed iscWeightEventResource.json to use these. See PR #67