search

integromat / vscode-apps-sdk

Integromat Apps SDK plugin for Visual Studio Code
https://github.com/integromat/mono/blob/master/libs/github-resources/src/repositories/vscode-apps-sdk.ts
Other
39 stars 12 forks source link

Let's use .iml.jsonc extension instead of .iml.json #193

Open shumov opened 3 months ago

shumov commented 3 months ago

Amazing product. Love it!

Why do files created in JSONC format use the .json extension? The file ends up in an invalid format, causing errors:

GitLab shows an error image
All other editors show an error as well image

When I manually change the file extension, everything works fine, but the syntax highlighting in VSCode stops working.

shumov commented 3 months ago

I created this PR use iml.jsonc instead of iml.json #194

ma-zal commented 2 months ago

Hi @shumov. Did you try to rename file(s) to .jsonc to check if you see highlights correctly in GitLab and in your IDE (it looks like JetBrains)? I am a bit afraid of some editors/viewers, which decide the .jsonc as plaintext only.

ma-zal commented 2 months ago

After considering it, I offer the backward compatible solution. We can keep the json as default, but we will add a new configuration option:

In settings.json:

// Overrides the default extension of created JSONC files (default is `json`).
// Value can be `jsonc`.
"apps-sdk.localDev.defaultJsoncFileExtension": "jsonc",