Compilation error while building the aero image with gcc 7

[Trass3r]

Basically this patch is currently necessary: https://lists.01.org/pipermail/edk2-devel/2017-February/007329.html

repo init -u https://github.com/intel-aero/intel-aero-manifest.git -m v1.6.1.xml -b master
repo sync -j4

export TEMPLATECONF=../meta-intel-aero/conf/
source poky/oe-init-build-env

bitbake intel-aero-image
sed -ri "s/mStringFileName == '/mStringFileName == NULL || *mStringFileName == '/" tmp/work/x86_64-linux/ovmf-native/git-r0/git/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp

bitbake intel-aero-image

[sugnanprabhu]

@Trass3r Right way to apply additional patches would be to add .bbappend

Following is one of the example. https://github.com/intel-aero/meta-intel-aero/blob/master/recipes-devtools/rpm/rpm_%25.bbappend

[Trass3r]

It's just a quick hack. The omvf repository should be updated instead.

[avinash-palleti]

@Trass3r We have still not moved to gcc-7 that's why may be we didn't encounter this issue. I see the patch which you gave is outdated, in ovmf repository mStringFileName is already compared with NULL. https://github.com/tianocore/edk2/blob/master/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp#L3509

Following commit already made a change to master branch, https://github.com/tianocore/edk2/commit/d37fa01fbbe2cf0cd8b49069a71706a33cb4a53e

[Trass3r]

Indeed. The other existing patches need to be updated.

[anselmolsm]

It's just a quick hack. The omvf repository should be updated instead.

omvf recipes are part of Yocto Project's poky. omvf has been updated in pyro branch already.

The manifest file for 1.6.1 can't be modified (thus it needs gcc 6). For build with gcc 7 you can use the devel manifest file (default.xml) instead as it tracks the HEAD of the poky pyro branch. Alternatively, you can just update your local poky clone to get the patch linked above. Thanks