search

intel-analytics / analytics-zoo

Distributed Tensorflow, Keras and PyTorch on Apache Spark/Flink & Ray
https://analytics-zoo.readthedocs.io/
Apache License 2.0
16 stars 3 forks source link

Duplicate PytorchModel and cpp files in zoo and zoo-core #1003

Closed hkvision closed 5 years ago

hkvision commented 5 years ago

https://github.com/intel-analytics/analytics-zoo-core/blob/master/torchnet/src/main/java/com/intel/analytics/zoo/pipeline/api/net/PytorchModel.java https://github.com/intel-analytics/analytics-zoo/blob/master/zoo/src/main/java/com/intel/analytics/zoo/pipeline/api/net/PytorchModel.java

These two files are different in zoo and zoo-core. And when I view in IDE, the compiled class in zoo-core shadows the one in zoo, which is annoying.

hhbyyh commented 5 years ago

We can move all the native code to zoo-core.