ywang19
commented
9 years ago Yes, it’s an issue, I will update the binary package soon.
Thanks, -yaguang From: Zoran Rajic [mailto:notifications@github.com] Sent: Tuesday, April 14, 2015 8:42 AM To: intel-cloud/cosbench Subject: [cosbench] v0.4.2.c1: Swift/Keystone regression (#267)
It seems there is a regression with the Swift storage using Keystone authentication, introduced on v0.4.2.c1 branch: the code is ignoring the Keystone authentication, and defaults to internal authentication values. This used to work correctly on v0.4.1.
The following change seems to be the root-cause:
- from 216d31bhttps://github.com/intel-cloud/cosbench/commit/216d31bd24c413a90c94d1f81a1023f0a6f8162e: --- a/dev/cosbench-driver/src/com/intel/cosbench/driver/agent/AuthAgent.java +++ b/dev/cosbench-driver/src/com/intel/cosbench/driver/agent/AuthAgent.java @@ -74,6 +74,8 @@ class AuthAgent extends AbstractAgent { private AuthContext login() { Logger logger = getMissionLogger(); AuthAPI authApi = workerContext.getAuthApi();
- if(authApi instanceof NoneAuth) // bypass caching handling for NoneAuth.
- return null; int attempts = 0; while (attempts++ < loginAttempts - 1) try {
Since the KeystoneAuth is actually a subclass of NoneAuth, the 'null' is returned; this causes SwiftStorage.setAuthContext() to use the default settings (authToken=AUTH_xxx, storageUrl=http://127.0.0.1:8080/auth/v1.0), and the KeystoneAuth object is never used.
— Reply to this email directly or view it on GitHubhttps://github.com/intel-cloud/cosbench/issues/267.
It seems there is a regression with the Swift storage using Keystone authentication, introduced on v0.4.2.c1 branch: the code is ignoring the Keystone authentication, and defaults to internal authentication values. This used to work correctly on v0.4.1.
The following change seems to be the root-cause:
Since the KeystoneAuth is actually a subclass of NoneAuth, the 'null' is returned; this causes SwiftStorage.setAuthContext() to use the default settings (authToken=AUTH_xxx, storageUrl=http://127.0.0.1:8080/auth/v1.0), and the KeystoneAuth object is never used.