intel-cloud / cosbench

a benchmark tool for cloud object storage service
Other
573 stars 242 forks source link

S3: Timeout modifies only the connection timeout #270

Closed zoran-rajic closed 9 years ago

zoran-rajic commented 9 years ago

Specifying the timeout value in the S3 workload, ie:

  <storage type="s3" config="timeout=600000;accesskey=AKIA..."/>

.. modifies only the socket connection timeout.

Expectation:

ywang19 commented 9 years ago

Yes, it’s an expected enhancement. So far only one timeout value, from my perspective, more tcp settings could be added as options beside those two timeouts.

-yaguang

From: Zoran Rajic [mailto:notifications@github.com] Sent: Thursday, April 30, 2015 3:55 PM To: intel-cloud/cosbench Subject: [cosbench] S3: Timeout modifies only the connection timeout (#270)

Specifying the timeout value in the S3 workload, ie:

.. modifies only the socket connection timeout.

Expectation:

  • the given timeout should modify both socket-connection, and socket-inactivity timeouts.

— Reply to this email directly or view it on GitHubhttps://github.com/intel-cloud/cosbench/issues/270.

zoran-rajic commented 9 years ago

Hello Yaguang,

It's good to know you were preparing the same enhancement. Apropos, the fix is trivial (see https://github.com/zoran-rajic/cosbench/commit/8f1de4c2b8c0f5aa4cf695a086d5bb66fec32659).

Thanks, Zoran

ywang19 commented 9 years ago

Hi Zoran,

Could you pull your fix to upstream?

-yaguang

From: Zoran Rajic [mailto:notifications@github.com] Sent: Thursday, April 30, 2015 4:18 PM To: intel-cloud/cosbench Cc: Wang, Yaguang Subject: Re: [cosbench] S3: Timeout modifies only the connection timeout (#270)

Hello Yaguang,

It's good to know you were preparing the same enhancement. Apropos, the fix is trivial (see zoran-rajic@8f1de4chttps://github.com/zoran-rajic/cosbench/commit/8f1de4c2b8c0f5aa4cf695a086d5bb66fec32659).

Thanks, Zoran

— Reply to this email directly or view it on GitHubhttps://github.com/intel-cloud/cosbench/issues/270#issuecomment-97703576.

zoran-rajic commented 9 years ago

Hi Yaguang,

Created pull request @ https://github.com/intel-cloud/cosbench/pull/271

Thanks, Zoran