intel-gpu / documentation

8 stars 1 forks source link

Feedback on installation-guides/ubuntu/ubuntu-focal.html #35

Open dseynhae opened 2 years ago

dseynhae commented 2 years ago

The installation instructions use deprecated commands (apt-key), and are using unsafe methods (putting keys in the /etc/apt/trusted.gpg.d/ directory).

A better working sequence is:

   # Make sure that these packages are installed
   $ sudo apt install gpg-agent curl
   # Convenience variables
   $ key=/usr/share/keyrings/intel-graphics.gpg
   $ rep_key=https://repositories.intel.com/graphics/intel-graphics.key
   $ rep_url=https://repositories.intel.com/graphics/ubuntu
   $ rep_options="arch=amd64 signed-by=$key"
   $ rep_list=/etc/apt/sources.list.d/intel.list

   # Download and install ascii-armored key
   $ curl $rep_key | sudo gpg --dearmor --output $key

   # Add Intel repository to the apt source list
   $ echo "deb [$rep_options] $rep_url focal main" | sudo tee -a $rep_list

   # Download and install the driver packages
   $ sudo apt update
   $ sudo apt install \
     intel-opencl-icd \
     intel-level-zero-gpu level-zero \
     intel-media-va-driver-non-free libmfx1
tripzero commented 2 years ago

Thanks for the feedback! @jketreno, does the above changes seem reasonable to you?

dseynhae commented 2 years ago

The big differences:

The proposed installation instructions are in line with BKM (and what Microsoft and Google are already doing).

ketrintel commented 2 years ago

First, thank you @dseynhae for taking the time to both report the issue, and provide the details. For those reading this thread in the future, here is a link to a stackoverflow post about the apt-key deprecation.

@tripzero I'm +1 for the changes going into the documentation after you've verified they work smooth when copy/pasted to the console (it looks like they should.)

ChenKej1e commented 2 years ago

Hi @dseynhae , thanks for your feedback and solution to this issue. We will validate it and update the guide as soon as possible.