search

intel-staging / libptpmgmt_iaclocklib

The Clock Manager is a library for monitoring network time synchronization on the local platform. Disclaimer: This project is under development. All source code and features on the main branch is for the purpose of testing or evaluation and not production ready. We will upstream the code and archive this GitHub repo thereafter.
Other
4 stars 6 forks source link

jclklib: Refactor servo lock status assignment in event_handle #100

Closed JunAnnLaiIntel closed 1 month ago

JunAnnLaiIntel commented 1 month ago

The previous implementation extracted the servo_state and used it to determine the servo_locked status. This has been refactored to directly use the portState to set servo_locked.

yoongsiang2 commented 1 month ago

Add new patch in your PR to resolve license issue, so that we can check whether CI is pass or fail

diff --git a/.reuse/dep5 b/.reuse/dep5 index 0b2e4e3..81aa787 100644 --- a/.reuse/dep5 +++ b/.reuse/dep5 @@ -9,6 +9,10 @@ Files: */changelog Copyright: 2021 © Erez Geva License: GFDL-1.3-no-invariants-or-later

+Files: jclklib/image/*.png +Copyright: 2024 © Intel Corporation +License: GFDL-1.3-no-invariants-or-later + Files: debian/co* debian/source/format Copyright: 2021 © Erez Geva License: GPL-3.0-or-later

AzuraTarmiziIntel commented 1 month ago

Hi peter,

great work.

I would like to request for the first change to be squashed with the second commit (servo_state changes)

Because the idea is to have at each commit - the compilation should pass. this is to avoid difficult cherry-picking in later stage.