intel / ACON

Apache License 2.0
57 stars 18 forks source link

scripts/acon-build.env: Request tty only if stdin is tty #31

Closed binxing closed 1 year ago

binxing commented 1 year ago

This commit addresses #28 by testing if stdin is tty before appending -t option to docker command line.

binxing commented 1 year ago

@billionairiam, I added one more step in the script to chown the dependence directory to the UID:GID specified by $U env var. Setting U=. will cause the script to use the current user's UID:GID. With that said, U=. start_rust_buildenv should solve the 2nd problem.

billionairiam commented 1 year ago

@billionairiam, I added one more step in the script to chown the dependence directory to the UID:GID specified by $U env var. Setting U=. will cause the script to use the current user's UID:GID. With that said, U=. start_rust_buildenv should solve the 2nd problem.

Sure, maybe we can merge this PR and then test the action again.