search

intel / DML

Intel® Data Mover Library (Intel® DML)
https://intel.github.io/DML/
MIT License
81 stars 17 forks source link

include/dml/detail/ml/buffer.hpp uses std::exchange but does not #include <utility> #22

Closed fenrus75 closed 1 year ago

fenrus75 commented 1 year ago

/builddir/build/BUILD/DML-1.0.0/sources/c_api/../../include/dml/detail/ml/buffer.hpp:53:36: error: ‘exchange’ is not a member of ‘std’

std::exchange is in the utility header which isn't included

mzhukova commented 1 year ago

Hi @fenrus75 thanks for catching this! Could you let me know what compiler you were using?

fenrus75 commented 1 year ago

fixed in pull request #23

I'm using gcc 12 with latest glibc

mzhukova commented 1 year ago

Merged in https://github.com/intel/DML/commit/3d638bf9de4d5be803c8a66a4acf6037fe235184. Please let me know if I can close the issue.

fenrus75 commented 1 year ago

thanks for fixing!

fenrus75 commented 1 year ago

btw somehow something went weird in the pull request since git munged the authorship of the patch ???